-
Notifications
You must be signed in to change notification settings - Fork 276
Add 'agent: BoltAgent' listener argument #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
fadc1a4
10c56e9
e6e456a
d0752cb
c332128
1a73ac4
7722f3e
c7e0089
5335855
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,9 @@ venv/ | |
| .venv* | ||
| .env/ | ||
|
|
||
| # claude | ||
| .claude/*.local.json | ||
|
|
||
| # codecov / coverage | ||
| .coverage | ||
| cov_* | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| from .agent import BoltAgent | ||
|
|
||
| __all__ = [ | ||
| "BoltAgent", | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| from typing import Optional | ||
|
|
||
| from slack_sdk import WebClient | ||
| from slack_sdk.web.chat_stream import ChatStream | ||
|
|
||
|
|
||
| class BoltAgent: | ||
| """Agent listener argument for building AI-powered Slack agents. | ||
| Experimental: | ||
| This API is experimental and may change in future releases. | ||
|
Comment on lines
+10
to
+11
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: We're using an "Experimental" warning while we developer this feature. Rather than working on a long-standing branch, we'd like to merge into |
||
| FIXME: chat_stream() only works when thread_ts is available (DMs and threaded replies). | ||
| It does not work on channel messages because ts is not provided to BoltAgent yet. | ||
|
Comment on lines
+13
to
+14
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: Important callout. I'd like to add |
||
| @app.event("app_mention") | ||
| def handle_mention(agent): | ||
| stream = agent.chat_stream() | ||
| stream.append(markdown_text="Hello!") | ||
| stream.stop() | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| *, | ||
| client: WebClient, | ||
| channel_id: Optional[str] = None, | ||
| thread_ts: Optional[str] = None, | ||
| team_id: Optional[str] = None, | ||
| user_id: Optional[str] = None, | ||
| ): | ||
| self._client = client | ||
| self._channel_id = channel_id | ||
| self._thread_ts = thread_ts | ||
| self._team_id = team_id | ||
| self._user_id = user_id | ||
|
|
||
| def chat_stream( | ||
| self, | ||
| *, | ||
| channel: Optional[str] = None, | ||
| thread_ts: Optional[str] = None, | ||
| recipient_team_id: Optional[str] = None, | ||
| recipient_user_id: Optional[str] = None, | ||
| **kwargs, | ||
| ) -> ChatStream: | ||
| """Creates a ChatStream with defaults from event context. | ||
| Each call creates a new instance. Create multiple for parallel streams. | ||
| Args: | ||
| channel: Channel ID. Defaults to the channel from the event context. | ||
| thread_ts: Thread timestamp. Defaults to the thread_ts from the event context. | ||
| recipient_team_id: Team ID of the recipient. Defaults to the team from the event context. | ||
| recipient_user_id: User ID of the recipient. Defaults to the user from the event context. | ||
| **kwargs: Additional arguments passed to ``WebClient.chat_stream()``. | ||
| Returns: | ||
| A new ``ChatStream`` instance. | ||
| """ | ||
| resolved_channel = channel or self._channel_id | ||
| resolved_thread_ts = thread_ts or self._thread_ts | ||
|
Comment on lines
+61
to
+62
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm wondering here if falling back to the class instances Like if a developer only passes one of these parameters and are unaware of the the fallback values they could end up chat streaming to the wrong location?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💭 i agree with @WilliamBergamin! |
||
| if resolved_channel is None: | ||
| raise ValueError( | ||
| "channel is required: provide it as an argument or ensure channel_id is set in the event context" | ||
| ) | ||
| if resolved_thread_ts is None: | ||
| raise ValueError( | ||
| "thread_ts is required: provide it as an argument or ensure thread_ts is set in the event context" | ||
| ) | ||
| return self._client.chat_stream( | ||
| channel=resolved_channel, | ||
| thread_ts=resolved_thread_ts, | ||
| recipient_team_id=recipient_team_id or self._team_id, | ||
| recipient_user_id=recipient_user_id or self._user_id, | ||
| **kwargs, | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| from typing import Optional | ||
|
|
||
| from slack_sdk.web.async_client import AsyncWebClient | ||
| from slack_sdk.web.async_chat_stream import AsyncChatStream | ||
|
|
||
|
|
||
| class AsyncBoltAgent: | ||
| """Async agent listener argument for building AI-powered Slack agents. | ||
|
|
||
| Experimental: | ||
| This API is experimental and may change in future releases. | ||
|
|
||
| @app.event("app_mention") | ||
| async def handle_mention(agent): | ||
| stream = await agent.chat_stream() | ||
| await stream.append(markdown_text="Hello!") | ||
| await stream.stop() | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| *, | ||
| client: AsyncWebClient, | ||
| channel_id: Optional[str] = None, | ||
| thread_ts: Optional[str] = None, | ||
| team_id: Optional[str] = None, | ||
| user_id: Optional[str] = None, | ||
| ): | ||
| self._client = client | ||
| self._channel_id = channel_id | ||
| self._thread_ts = thread_ts | ||
| self._team_id = team_id | ||
| self._user_id = user_id | ||
|
|
||
| async def chat_stream( | ||
| self, | ||
| *, | ||
| channel: Optional[str] = None, | ||
| thread_ts: Optional[str] = None, | ||
| recipient_team_id: Optional[str] = None, | ||
| recipient_user_id: Optional[str] = None, | ||
| **kwargs, | ||
| ) -> AsyncChatStream: | ||
| """Creates an AsyncChatStream with defaults from event context. | ||
|
|
||
| Each call creates a new instance. Create multiple for parallel streams. | ||
|
|
||
| Args: | ||
| channel: Channel ID. Defaults to the channel from the event context. | ||
| thread_ts: Thread timestamp. Defaults to the thread_ts from the event context. | ||
| recipient_team_id: Team ID of the recipient. Defaults to the team from the event context. | ||
| recipient_user_id: User ID of the recipient. Defaults to the user from the event context. | ||
| **kwargs: Additional arguments passed to ``AsyncWebClient.chat_stream()``. | ||
|
|
||
| Returns: | ||
| A new ``AsyncChatStream`` instance. | ||
| """ | ||
| resolved_channel = channel or self._channel_id | ||
| resolved_thread_ts = thread_ts or self._thread_ts | ||
| if resolved_channel is None: | ||
| raise ValueError( | ||
| "channel is required: provide it as an argument or ensure channel_id is set in the event context" | ||
| ) | ||
| if resolved_thread_ts is None: | ||
| raise ValueError( | ||
| "thread_ts is required: provide it as an argument or ensure thread_ts is set in the event context" | ||
| ) | ||
| return await self._client.chat_stream( | ||
| channel=resolved_channel, | ||
| thread_ts=resolved_thread_ts, | ||
| recipient_team_id=recipient_team_id or self._team_id, | ||
| recipient_user_id=recipient_user_id or self._user_id, | ||
| **kwargs, | ||
| ) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| from typing import Optional | ||
| from typing import TYPE_CHECKING, Optional | ||
|
|
||
| from slack_sdk.web.async_client import AsyncWebClient | ||
|
|
||
|
|
@@ -15,6 +15,9 @@ | |
| from slack_bolt.context.set_title.async_set_title import AsyncSetTitle | ||
| from slack_bolt.util.utils import create_copy | ||
|
|
||
| if TYPE_CHECKING: | ||
| from slack_bolt.agent.async_agent import AsyncBoltAgent | ||
|
|
||
|
Comment on lines
+18
to
+20
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TIL: TYPE_CHECKING, it seems awesome and maybe we can use it elsewhere to improve our types checking for async stuff IIUC this is to ensure that we
|
||
|
|
||
| class AsyncBoltContext(BaseContext): | ||
| """Context object associated with a request from Slack.""" | ||
|
|
@@ -187,6 +190,34 @@ async def handle_button_clicks(context): | |
| self["fail"] = AsyncFail(client=self.client, function_execution_id=self.function_execution_id) | ||
| return self["fail"] | ||
|
|
||
| @property | ||
| def agent(self) -> "AsyncBoltAgent": | ||
| """`agent` listener argument for building AI-powered Slack agents. | ||
|
|
||
| Experimental: | ||
| This API is experimental and may change in future releases. | ||
|
|
||
| @app.event("app_mention") | ||
| async def handle_mention(agent): | ||
| stream = await agent.chat_stream() | ||
| await stream.append(markdown_text="Hello!") | ||
| await stream.stop() | ||
|
|
||
| Returns: | ||
| `AsyncBoltAgent` instance | ||
| """ | ||
| if "agent" not in self: | ||
| from slack_bolt.agent.async_agent import AsyncBoltAgent | ||
|
|
||
| self["agent"] = AsyncBoltAgent( | ||
| client=self.client, | ||
| channel_id=self.channel_id, | ||
| thread_ts=self.thread_ts, | ||
| team_id=self.team_id, | ||
| user_id=self.user_id, | ||
| ) | ||
| return self["agent"] | ||
|
|
||
| @property | ||
| def set_title(self) -> Optional[AsyncSetTitle]: | ||
| return self.get("set_title") | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ def build_async_required_kwargs( | |
| error: Optional[Exception] = None, # for error handlers | ||
| next_keys_required: bool = True, # False for listeners / middleware / error handlers | ||
| ) -> Dict[str, Any]: | ||
| all_available_args = { | ||
| all_available_args: Dict[str, Any] = { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: This fixed a linter warning |
||
| "logger": logger, | ||
| "client": request.context.client, | ||
| "req": request, | ||
|
|
@@ -83,6 +83,10 @@ def build_async_required_kwargs( | |
| if k not in all_available_args: | ||
| all_available_args[k] = v | ||
|
|
||
| # Defer agent creation to avoid constructing AsyncBoltAgent on every request | ||
| if "agent" in required_arg_names or "args" in required_arg_names: | ||
| all_available_args["agent"] = request.context.agent | ||
|
Comment on lines
+87
to
+88
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clever 💯 I like this and wonder if we should follow this pattern for other keyword arguments 🚀 What do you think about including a warning here that informs developers that the agent is an experimental feature subject to change? From what I can tell we should be able to do this by taking advantage of the FutureWarning like this import warnings
class ExperimentalWarning(FutureWarning):
"""Warning for features that are still in experimental phase."""
pass
warnings.warn(
"agent is experimental and may change in future versions.",
category=ExperimentalWarning,
stacklevel=2
)IIUC every time a handler processes a request and uses the "agent" kwargs, this warning would be printed, this might be a bit annoying but it would be clear |
||
|
|
||
| if len(required_arg_names) > 0: | ||
| # To support instance/class methods in a class for listeners/middleware, | ||
| # check if the first argument is either self or cls | ||
|
|
@@ -102,7 +106,7 @@ def build_async_required_kwargs( | |
| for name in required_arg_names: | ||
| if name == "args": | ||
| if isinstance(request, AsyncBoltRequest): | ||
| kwargs[name] = AsyncArgs(**all_available_args) # type: ignore[arg-type] | ||
| kwargs[name] = AsyncArgs(**all_available_args) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: The above fix allows us to remove this type ignore |
||
| else: | ||
| logger.warning(f"Unknown Request object type detected ({type(request)})") | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Maybe we should wait until the feature is GA before exporting it here?
Developers should still be able to import the class directly with something like
from slack_bolt.agent import BoltAgent