fix: pin setuptools to maintain support for pyramid adapter #1436
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The pyramid framework is dependent on setuptools
pkg_resourcesmodule. This module has been deprecated since setuptools v67.5.0 and removed in setuptools v82.0.0. See Pylons/pyramid#3731 for all the details.These changes pins setuptools v82.0.0 when unit testing the project in order to allow the tests around the Pyramid Adapter to run.
When pyramids dependence on
pkg_resourcesis resolved we should remove the setuptools v82.0.0 pin.Testing
Continuous integration tests should be sufficient
You can also pull this branch and run the tests locally, everything should pass
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.