fix(executor): handle condition dead-end branches in loops#2944
Merged
waleedlatif1 merged 6 commits intostagingfrom Jan 22, 2026
Merged
fix(executor): handle condition dead-end branches in loops#2944waleedlatif1 merged 6 commits intostagingfrom
waleedlatif1 merged 6 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant User
participant EdgeManager
participant DAG
User->>EdgeManager: "processOutgoingEdges(node, output)"
EdgeManager->>EdgeManager: "evaluate each outgoing edge"
EdgeManager->>EdgeManager: "shouldActivateEdge(edge, output)"
EdgeManager->>EdgeManager: "collect activated targets"
EdgeManager->>EdgeManager: "collect edges to deactivate"
EdgeManager->>EdgeManager: "deactivateEdgeAndDescendants()"
EdgeManager->>DAG: "remove incoming edges from activated targets"
EdgeManager->>EdgeManager: "isTargetReady() for each target"
EdgeManager-->>User: "return ready node IDs"
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Author
|
@greptile |
Collaborator
|
@cursor review |
waleedlatif1
added a commit
that referenced
this pull request
Jan 22, 2026
…lution consolidation, helm updates (#2946) * improvement(workflow-item): stabilize avatar layout and fix name truncation (#2939) * improvement(workflow-item): stabilize avatar layout and fix name truncation * fix(avatars): revert overflow bg to hardcoded color for contrast * fix(executor): stop parallel execution when block errors (#2940) * improvement(helm): add per-deployment extraVolumes support (#2942) * fix(gmail): expose messageId field in read email block (#2943) * fix(resolver): consolidate reference resolution (#2941) * fix(resolver): consolidate code to resolve references * fix edge cases * use already formatted error * fix multi index * fix backwards compat reachability * handle backwards compatibility accurately * use shared constant correctly * feat(router): expose reasoning output in router v2 block (#2945) * fix(copilot): always allow, credential masking (#2947) * Fix always allow, credential validation * Credential masking * Autoload * fix(executor): handle condition dead-end branches in loops (#2944) --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isCascadeparam to distinguish direct vs cascade deactivation targetsType of Change
Testing
Tested with unit tests (52 pass)
Checklist