Do not listen to lifecycle events on Mac Catalyst#60
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes lifecycle event observation functionality for the SQLiteDatabase class and adds conditional compilation to prevent app lifecycle notifications from being registered on Mac Catalyst.
- Removes
observeLifecycleEventsparameter from database initialization methods - Updates conditional compilation to exclude Mac Catalyst from UIKit-based lifecycle handling
- Always calls
registerForAppNotifications()without conditional logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@myobie I merged your pull request. Then, after pulling that change into the iOS app, I thought to myself, when would anyone ever want to listen to those lifecycle events on Mac Catalyst? So, I figured I'd just remove them here inside of SQLite and remove the need for the extra argument and compilation condition inside of our iOS app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.