SES-5170 : Groups show 'Leave' option twice #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val groupV2Id = (address as? Address.Group)?.accountId ?: return | ||
| val isAdmin = groupManagerV2.isCurrentUserGroupAdmin(groupV2Id) | ||
|
|
||
| if (isAdmin == null) return |
Collaborator
There was a problem hiding this comment.
Is it dangerous to mix up non-existing groups with admin logic?
It's not obvious that a null admin means no group.
Collaborator
Author
There was a problem hiding this comment.
Hmm, would an explicit check be better here?
val groupInfo = configFactory.getGroup(groupV2Id)
if (groupInfo == null) return
Collaborator
There was a problem hiding this comment.
I think that's true for the overall chance of isAdmin being nullable throughout? Is it misleading to add this nullable case to use as a way to say the group doesn't exist? It feels like a separate thing than the admin state
Collaborator
Author
There was a problem hiding this comment.
Hmm makes sense. I removed the check from the group manager, added checks for groupInfo instead and check the admin key from that.
…-android into fix/convo-bottom-sheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates logic for checking if the user is a group admin and adds that logic to the context menu on conversation long-press.