[Feature] Improve Typescript SQS standard example#710
Open
Pigius wants to merge 2 commits intoserverless:v3from
Open
[Feature] Improve Typescript SQS standard example#710Pigius wants to merge 2 commits intoserverless:v3from
Pigius wants to merge 2 commits intoserverless:v3from
Conversation
Contributor
mnapoli
reviewed
Aug 22, 2022
Contributor
mnapoli
left a comment
There was a problem hiding this comment.
Thanks! I added some inline comments for improvements.
Contributor
Author
|
Hi @mnapoli sorry, I did not receive any GH notifications, so, I was not aware of your comments. I've fixed them now! |
15ba239 to
53420c5
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pgrzesik!
Couple of improvements: