Conversation
Member
|
Thanks @heinrichschiller Please also add php 8.3 and 8.4 to the build.yml file. Thanks. |
Contributor
Author
|
Sorry. I didn't know that until today and haven't used it. |
This reverts commit 94611dd.
Contributor
Author
|
New attempt. I actually wanted to leave the old PHP versions in and avoid unnecessary changes. Now I've just used the supported PHP versions, see https://www.php.net/supported-versions.php. I don't know what to do with overtrue/phplint; it already requires at least PHP 8.2. Is that important here? As I understand it, the IDE PHPStorm needs it. I don't use it, for example. |
Member
|
There is a small code style issue. To fix it run composer cs:fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here are some updates I have made.
Tests show that it should continue to work. I updated PHPUnit, which took some work because I don't know everything. Hopefully, it should be fine.
Best regards,
Heinrich Schiller