Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes five new accessibility-related fields across the codebase to provide more detailed information about seat characteristics for users with disabilities.
Changes:
- Added five new boolean accessibility fields:
has_lift_up_armrests,is_hearing_impaired,is_semi_ambulatory_seat,has_sign_language_interpretation, andis_plus_size - Updated domain models to extract these fields from API responses
- Extended test coverage to validate the new fields in both event and chart report tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| seatsio/domain.py | Added five new accessibility field assignments in both ChartReportItem and EventReportItem classes |
| tests/reports/events/testEventReports.py | Added assertions for the new accessibility fields in both seated and GA test cases |
| tests/reports/charts/testChartReports.py | Added assertions for the new accessibility fields and changed existing accessibility assertions from is_not_none() to is_false() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| self.is_accessible = item_data.get("isAccessible") | ||
| self.is_companion_seat = item_data.get("isCompanionSeat") | ||
| self.has_lift_up_armrests = item_data.get("hasLiftUpArmrests") | ||
| self.is_hearing_impaired = item_data.get("isHearingImpaired") |
There was a problem hiding this comment.
The field name 'is_hearing_impaired' uses potentially outdated terminology. Consider using more inclusive language such as 'is_deaf_or_hard_of_hearing' or 'requires_hearing_accessibility' to align with current accessibility best practices.
Suggested change
| self.is_hearing_impaired = item_data.get("isHearingImpaired") | |
| self.is_deaf_or_hard_of_hearing = item_data.get("isHearingImpaired") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.