[FEATURE] WaveNet: Allow different activations, gating modes, and secondary activations in each layer of a layer array #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated LayerArrayParams to accept a vector of activation configurations, allowing each layer to have its own activation setting. - Modified constructors and relevant methods in _LayerArray and _Layer to handle the new activation_configs parameter. - Added validation to ensure the sizes of dilations and activation_configs match. - Updated tests to create LayerArrayParams with multiple activation configurations based on dilations size.
- Introduced a new test function `test_layer_array_different_activations` to validate the behavior of a layer array using various activation functions (ReLU, Tanh, Sigmoid) across its layers. - Updated `run_tests.cpp` to include the new test, ensuring comprehensive coverage of activation configurations. - The test verifies that outputs differ when using mixed activations compared to an all-ReLU configuration, confirming the correct implementation of activation behavior.
…ivations - Updated LayerArrayParams and related classes to accept vectors for gating modes and secondary activation configurations, allowing each layer to have distinct settings. - Modified constructors and validation logic to ensure sizes of dilations, activation configurations, gating modes, and secondary activations match. - Adjusted tests to create LayerArrayParams with multiple gating modes and secondary activations based on dilations size, ensuring comprehensive coverage of the new functionality.
sdatkinson
changed the title
sdatkinson
commented
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #206