-
Notifications
You must be signed in to change notification settings - Fork 100
Confirm dialog #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm dialog #562
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: All's working really well here, @catreedle! This is a perfect implementation given the current state of the app. Let's finalize the texts as soon as we can in #563 and #564 so that we don't have the xcstrings files being edited all the time anymore 🤔 I'll make issues for the rest of the work needed for the data download UI 🥳
|
Making it that this PR will close #559. We can have moving it to the correct page be a part of the data download UI issue :) |
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
This PR adds a reusable confirmation dialog for translation source–related actions and integrates it into the language source change flow.
Related issue