Skip to content

Conversation

@catreedle
Copy link
Collaborator

@catreedle catreedle commented Dec 23, 2025

Contributor checklist


Description

This PR adds a reusable confirmation dialog for translation source–related actions and integrates it into the language source change flow.

  • Add ConfirmDialogView for confirming download translation source
  • Add parameters for ConfirmDialogView
  • Navigate to Translation language source on clicking Change language
  • Add confirmation dialog on changing source language

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's working really well here, @catreedle! This is a perfect implementation given the current state of the app. Let's finalize the texts as soon as we can in #563 and #564 so that we don't have the xcstrings files being edited all the time anymore 🤔 I'll make issues for the rest of the work needed for the data download UI 🥳

@andrewtavis
Copy link
Member

Making it that this PR will close #559. We can have moving it to the correct page be a part of the data download UI issue :)

@andrewtavis andrewtavis merged commit c034fe4 into scribe-org:main Dec 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tooltip to check translation source language

2 participants