-
Notifications
You must be signed in to change notification settings - Fork 101
Fix inconsistent border radius across application (#555) and (#552) #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent border radius across application (#555) and (#552) #560
Conversation
- Standardized border radius for cards and UI elements - Updated liquid-glass tab bar styling to match modern iOS design - Applied consistent corner radius across InformationScreenVC, SettingsViewController, TipCardView, and table view cells - Ensures uniform appearance across iOS 26 Simulator Fixes scribe-org#555
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-iOS repo (can be set withgit config --global user.email "GITHUB_EMAIL")
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: @prince-0408, I think it's best if we go with @catreedle's fix for the border radius in #558, but we can bring in the liquid glass changes from this PR :)
praise: Thanks so much for your work here and your patience! Great to have you in the community, and we hope we can continue to work with you! Please let us know if there are issues you'd be interested in working on, and if there are, then you can write in the issue and ask to be assigned 😊
Fixes #552
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
This PR fixes inconsistent border radius styling and improves the liquid-glass tab bar design, addressing issues #555 and #552.
Changes made:
InformationScreenVC.swift(About screen)SettingsViewController.swift(Settings screen)TipCardView.swiftInfoChildTableViewCell.swiftRadioTableViewCell.swiftVisual improvements:
Testing:
Tested on iOS Simulator and verified:
Screenshots:
Before and after comparisons showing the improved border radius consistency and tab bar styling.
Related issue
Closes #552

