[UEPR-454] Add translations to "aria-label"s in editor #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The aria-labels don't seem to change after language switch, should be tested with a real screen reader. |
Contributor
|
@kbangelov that makes sense, since they were just added as translation "objects" (and are not even yet pushed to Transifex -> they are not translated there) - hence the code has no reference point for those strings to draw from for other languages and it defaults to English. We can test that the translation logic works by manually modifying the translation files generated by scratch-l10n. |
KManolov3
approved these changes
Jan 5, 2026
Contributor
KManolov3
left a comment
KManolov3
left a comment
There was a problem hiding this comment.
We should test the translated labels get picked up by a screen reader, but otherwise looks good to me 🙌
adzhindzhi
approved these changes
Jan 5, 2026
Contributor
Author
|
I tested with custom german translations and it seemed to work fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-454
Proposed Changes
added intl.formatMessage logic