Skip to content

Remove all usage of url field #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanv wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −9
Open

Remove all usage of url field #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/test_calendar.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ events:
# All-day event
- summary: Earth Day
begin: 2021-04-22
url: https://earthday.org
location: https://earthday.org
repeat:
interval:
# seconds, minutes, hours, days, weeks, months, years
Expand Down
2 changes: 1 addition & 1 deletion tests/test_calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def test_calendar_event():
events:
- summary: Earth Day
begin: 2021-04-22
url: https://earthday.org
location: https://earthday.org
location: Earth
"""
)
Expand Down
10 changes: 3 additions & 7 deletions tests/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ def test_basic_structure():
"""
summary: Earth Day
begin: 2021-04-22
url: https://earthday.org
location: Earth
location: https://earthday.org
"""
)
)
Expand All @@ -23,8 +22,7 @@ def test_basic_structure():
for line in lines[:-1]:
assert line.endswith("\r")
assert "SUMMARY:Earth Day" in event_str
assert "URL:https://earthday.org" in event_str
assert "LOCATION:Earth" in event_str
assert "LOCATION:https://earthday.org" in event_str
# All events must have a DTSTAMP
assert "DTSTAMP" in event_str

Expand All @@ -35,7 +33,7 @@ def test_all_day_event():
"""
summary: Earth Day
begin: 2021-04-22
url: https://earthday.org
location: https://earthday.org
"""
)
)
Expand All @@ -53,7 +51,6 @@ def test_rrule():
"""
summary: Earth Day
begin: 2021-04-22
url: https://earthday.org
repeat:
interval:
years: 1
Expand Down Expand Up @@ -139,7 +136,6 @@ def test_event_with_custom_ics():
"""
summary: Earth Day
begin: 2021-04-22
url: https://earthday.org
ics: |
RRULE:FREQ=YEARLY;UNTIL=20280422T000000
"""
Expand Down
Loading