Generalize package name, add -Environment for Win/Linux#14
Merged
drammock merged 4 commits intoscientific-python:mainfrom Jun 2, 2025
Merged
Generalize package name, add -Environment for Win/Linux#14drammock merged 4 commits intoscientific-python:mainfrom
drammock merged 4 commits intoscientific-python:mainfrom
Conversation
matthew-brett
force-pushed
the
rename-environment
branch
from
8db5b89 to
3b3e16f
Compare
Contributor
Author
|
This seems to be working as expected now. |
drammock
reviewed
Jun 2, 2025
drammock
approved these changes
Jun 2, 2025
Member
|
+1 for merge-when-green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some machinery to get the package name from the
construct.yamlfile - so that people can more easily make a package with another name.Add
-Environmentto output folder for Windows and Linux, as per gh-7.