Avoid permission error on creating config file#2717
Merged
sachilles merged 1 commit intosameersbn:masterfrom Apr 21, 2023
Merged
Conversation
kkimurak
force-pushed
the
fix-permission-error-on-copying-database.yml-for-building-image
branch
from
ab694c8 to
b1301c1
Compare
Contributor
Author
|
rebased on current master (15.9.3) |
Collaborator
|
@kkimurak Sorry for the delay. Is the postioion you pointed out the only position that fails on rootless environments? |
Contributor
Author
|
@sachilles Yes I believe so, as far as I have been building image locally these years. But I have to say "I believe so", because I don't use all the features of gitlab. |
`assets/build/config/database.yml.postgresql` is owned by root:root,
and permission is rwxrw----
so the user `git` (`${GILTAB_USER}`) doesn't have a permission to copy the file.
This raises an error while building.
kkimurak
force-pushed
the
fix-permission-error-on-copying-database.yml-for-building-image
branch
from
b1301c1 to
029186d
Compare
Contributor
Author
|
rebased onto 15.10.3 |
kkimurak
deleted the
fix-permission-error-on-copying-database.yml-for-building-image
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assets/build/config/database.yml.postgresqlis owned by root:root, and permission is rwxrw----so the user
git(${GILTAB_USER}) doesn't have a permission to copy the file.This raises an permission error while building image locally if the docker is running on rootless environment (or the user is just a member of
dockergroup).This PR avoids this kind of issue by first copying the file as root and then changing the owner to the
GITLAB_USER.