Skip to content

Conversation

@nakrovati
Copy link
Contributor

@nakrovati nakrovati commented Jan 20, 2026

📝 Pull Request

📋 Description

  • Remove unused dependencies: @iconify/json, aws-sdk, universal-cookie, @inspira-ui/plugins, patch-package, tar, tailwindcss-animate (replaced with tw-animate-css in shadcn-vue);
  • Remove lodash - only the _.endsWith(...) method was used from it;
  • Update Vue, Nuxt, their modules, and some packages not related to shadcn-vue but which need to be updated for compatibility with Vue/Nuxt;
  • Move some dependencies to more appropriate categories (deps/devDeps);
  • Migrate CommonJS code to ESM;
  • Rewrite the tar version to =>7.5.4 due to a vulnerability (see commit message).

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Code refactoring
  • ⚡ Performance improvement
  • 🧪 Test improvements
  • 🔒 Security fix

🧪 Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Performance tests added/updated
  • Manual testing completed

Test Results

# 运行测试的命令和结果
npm run test

📊 Performance Impact

  • No performance impact
  • Performance improved
  • Performance impact analyzed and acceptable
  • Performance benchmarks included

🔒 Security Considerations

  • No security impact
  • Security review completed
  • Vulnerability assessment done
  • Security tests added

📚 Documentation

  • Code comments updated
  • README updated (if needed)
  • API documentation updated (if needed)
  • Changelog updated

✅ Checklist

Code Quality

  • Code follows the project's style guidelines
  • Self-review of the code completed
  • Code is properly commented
  • No console.log or debug statements left
  • TypeScript types are properly defined
  • All commit messages are in English (following Conventional Commits)

Testing

  • All existing tests pass
  • New tests cover the changes
  • Test coverage is maintained or improved
  • Edge cases are tested

Dependencies

  • No new dependencies added, or they are justified
  • Dependencies are up to date
  • No security vulnerabilities in dependencies

Compatibility

  • Changes are backward compatible
  • Browser compatibility maintained
  • Node.js version compatibility maintained

🔗 Related Issues

Closes #
Fixes #
Related to #

📸 Screenshots (if applicable)

Before After

🚀 Deployment Notes

  • No special deployment steps required
  • Database migration required
  • Configuration changes required
  • Environment variables updated

👥 Reviewers

Please review: @

📝 Additional Notes


🤖 Automated Checks

The following checks will be automatically performed:

  • ✅ Code formatting (Prettier)
  • ✅ Type checking (TypeScript)
  • ✅ Linting (ESLint)
  • ✅ Unit tests
  • ✅ Integration tests
  • ✅ Security scan
  • ✅ Performance tests
  • ✅ Build verification

📊 Code Coverage

Current coverage will be displayed here after the tests run.

⚡ Performance Benchmarks

Performance impact will be analyzed and displayed here.

@overtrue overtrue merged commit 20f090f into rustfs:main Jan 20, 2026
9 of 14 checks passed
@overtrue
Copy link
Collaborator

Thanks.

@nakrovati nakrovati deleted the chore/remove-unused-deps branch January 20, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants