Skip to content

Conversation

@newpavlov
Copy link
Member

This improves visibility of the tests and makes the modules less cluttered.

@newpavlov newpavlov requested a review from dhardy January 23, 2026 13:51
@dhardy
Copy link
Member

dhardy commented Jan 23, 2026

For lib.rs I agree that it's too cluttered. I considered moving the traits to sub-modules but at the time this would have conflicted with other changes; moving only the tests out is also fine.

For the other sub-modules, I don't see a strong motivation (especially utils which had few tests).

@newpavlov
Copy link
Member Author

For the other sub-modules, I don't see a strong motivation (especially utils which had few tests).

I plan to add several new tests for the utils functions to improve coverage. In general, I prefer to keep public API tests in the tests/ folder and use unit tests (i.e. mod tests) only for private APIs.

@newpavlov newpavlov merged commit bddeeab into master Jan 23, 2026
13 checks passed
@newpavlov newpavlov deleted the mv_tests branch January 23, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants