Rename (Try)RngCore to (Try)Rng
#54
Conversation
Co-authored-by: Tony Arcieri <bascule@gmail.com>
|
As someone who primarily uses |
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
I guess I should stop fighting this on the grounds that it is disruptive; mass-renames are not particularly hard (and this should require very few changes for someone using rand::prelude::*).
Any chance you could make a PR for rand and the book too?
| /// [`next_u32`]: RngCore::next_u32 | ||
| /// [`next_u64`]: RngCore::next_u64 | ||
| pub trait RngCore: TryRngCore<Error = Infallible> { | ||
| /// [`rand::RngExt`]: https://docs.rs/rand/latest/rand/trait.RngExt.html |
There was a problem hiding this comment.
Yes. I plan to rename the rand::Rng trait in the same PR which migrates to the renamed rand_core traits.
Will do, but I first need to migrate |
|
Hey guys, I understand that this is an rc crate so there are no version guarantees, but you are aware right, that every time you tweak the API and push a new version, downstream users are getting broken pipelines? I understand that sometimes API changes are needed, but it's seriously annoying that I have to debug on a saturday evening becase |
|
@karalabe you shouldn't need to use the latest RC version if you are not testing. The good news is that I think we don't have any more breaking changes before the next proper release of rand_core. |
|
I'm using the x-wing stuff from https://github.com/RustCrypto/KEMs, so unfortunately I inherit the issues. |
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
|
New |
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
Drop the "core" part to make the names shorter, less confusing, and more consistent with the crypto traits.
This change implies renaming of
rand::Rngtorand::RngExt.