Remove fn unwrap_mut #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
@newpavlov's suggestion: remove this fn
Motivation
UnwrapErr(rng)/UnwrapErr(&mut rng)are obvious counter-parts;rng.unwrap_err()vs(&mut rng).unwrap_err()are less obvious counter-parts.This seems fine to me. Counter-motivation would be convenience and potentially avoiding the need to import
UnwrapErr, but I don't see huge numbers of users of this anyway.Alternative
Add
fn unwrap_mut(&mut rng) -> UnwrapErr(&mut rng).