add kernel stack address to BootInfo #531
Conversation
Freax13
left a comment
Freax13
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Can we get a test for this? We could add a test that checks that a local stack variable lies within the address range reported in BootInfo.
api/src/info.rs
Outdated
| /// Virtual address of the start of the kernel stack | ||
| pub kernel_stack_addr: u64, |
There was a problem hiding this comment.
"start" can be a bit confusing because the stack grows down. Let's be clear that this is the lowest address of the stack, also sometimes referred to as the bottom of the stack.
Last time we didn't treat this as a breaking change, so we should be fine. |
The struct is marked as non-exhaustive, so adding fields should not break anybody. |
|
Any chance we can get a release anytime soon. I'm happy to create a PR to bump versions and update the changelog. That said it looks like the next version has to be a major version bump as we switched over to 2024 edition. |
That'd be greatly appreciated, thanks!
I don't think that's a breaking change though, is it? I can't find any documentation about whether this should be a minor or major change, but I can't think of a reason why it would be a breaking change. |
It requires a upgrade to the rust compiler. However now that I think about it, it shouldn't matter here. This is a nightly only crate and it is pretty much assumed that old nightly compilers might not work, e.g some unstable feature changed. So I guess minor change is ok. |
3 participants
I'm not sure if a change to
BootInforequires a version bump