Skip to content

join_path_syms_lazy #149936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
yotamofek wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

join_path_syms_lazy #149936

yotamofek wants to merge 1 commit into from
+34 −23

Conversation

@yotamofek
Copy link
Contributor

@yotamofek yotamofek commented Dec 13, 2025 •
edited by rustbot
Loading

Unrelated to, but inspired by, #149915 .
Let's see what this does to perf

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Dec 13, 2025
@yotamofek yotamofek marked this pull request as ready for review December 13, 2025 00:33
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@yotamofek yotamofek marked this pull request as draft December 13, 2025 00:34
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025
@yotamofek
Copy link
Contributor Author

yotamofek commented Dec 13, 2025

Sorry, didn't mean to mark this as ready to review, no need to review yet @GuillaumeGomez

@yotamofek
Copy link
Contributor Author

yotamofek commented Dec 13, 2025

Gonna (finally) go to sleep, and CI hasn't failed yet, so I'll trigger a perf run in the meantime.

@bors try @rust-timer queue profiles=Doc

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 13, 2025
@rust-bors
Auto merge of #149936 - yotamofek:pr/rustdoc/join_path_syms_lazy, r=<…
8b5f0cd 
…try>

`join_path_syms_lazy`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 13, 2025
@rust-bors
Copy link

rust-bors bot commented Dec 13, 2025

☀️ Try build successful (CI)
Build commit: 8b5f0cd (8b5f0cd2e0d097b6c352b7ccf9adfe3dbddedfd7, parent: dc47a69ed94bc88b10b7d500cceacf29b87bcbbe)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 13, 2025

Finished benchmarking commit (8b5f0cd): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.3%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.3%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.622s -> 477.006s (0.29%)
Artifact size: 389.31 MiB -> 389.32 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 13, 2025
GuillaumeGomez
GuillaumeGomez reviewed Dec 13, 2025
View reviewed changes
src/librustdoc/html/format.rs
path.iter()
.copied()
.map(|seg| Some(seg).filter(|seg| *seg != kw::PathRoot).maybe_display())
.joined("::", f)
Copy link
Member

@GuillaumeGomez GuillaumeGomez Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using intersperse instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yotamofek @rustbot @rust-timer @GuillaumeGomez