Refactor: Bidirectional messages #21340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the discussion in the Zulip thread: #t-compiler/rust-analyzer > proc-macro-srv: bidirectional messaging
At a high level, it removes the rigid
FnMutcallback introduced in the initial bidirectional messaging implementation on thesrvside, and instead introduces aProcMacroClientInterfacetrait owned by thesrv. This allows theclito implement the interface for any transport, without thesrvneeding to know about transport details. Thesrvsimply calls trait methods to obtain the data it needs.The PR also removes the duplicated
SubRequestandSubResponsetypes added in the earlier bidirectional PR,