Skip to content

Conversation

@anforowicz
Copy link
Contributor

@anforowicz anforowicz commented Jan 20, 2026

#3834 got initially merged while still being contained in text/0000-export-visibility.md. This PR renames the RFC so that it has a correct/actual number.

/cc @tmandry

Rendered

@anforowicz
Copy link
Contributor Author

AFAICT 3874 is free - the last biggest number is 3873:

$ ls text | sort --numeric-sort | tail
3772-build-target-edition.md
3791-crate-attr.md
3809-derive-from.md
3817-promote-aarch64-pc-windows-msvc-to-tier-1.md
3841-demote-x86_64-apple-darwin.md
3848-asm-const-ptr.md
3849-Project-Goals-2025h2.md
3872-crates-io-security.md
3873-build-std-context.md
3874-export-visibility.md

@zachs18
Copy link
Contributor

zachs18 commented Jan 20, 2026

IIUC, the RFC number should be the PR number that added the RFC, so would be 3834-... here.

In particular, it should not be named 3874-..., as RFC 3874 #3874 is something else (not yet merged, but in FCP with disposition merge).

@anforowicz anforowicz force-pushed the assign-proper-number-to-export-visibility-rfc branch from e9fdb94 to ab09fae Compare January 20, 2026 20:49
@anforowicz
Copy link
Contributor Author

IIUC, the RFC number should be the PR number that added the RFC, so would be 3834-... here.

Ooops. Fixed. Thanks for helping me figure out the logistical process here.

@ehuss ehuss changed the title git mv text/0000-export-visibility.md text/3874-export-visibility.md git mv text/0000-export-visibility.md text/38e4-export-visibility.md Jan 20, 2026
@ehuss ehuss changed the title git mv text/0000-export-visibility.md text/38e4-export-visibility.md git mv text/0000-export-visibility.md text/3834-export-visibility.md Jan 20, 2026
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit 11ca03e into rust-lang:master Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants