redox: add makedev, major, minor, and fix dev_t#4928
Merged
JohnTitor merged 1 commit intorust-lang:mainfrom Jan 17, 2026
Merged
redox: add makedev, major, minor, and fix dev_t#4928JohnTitor merged 1 commit intorust-lang:mainfrom
JohnTitor merged 1 commit intorust-lang:mainfrom
Conversation
Contributor
Author
|
Can this be backported to 0.2 and released? |
Member
|
Sure! |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Feb 9, 2026
(backport <rust-lang#4928>) (cherry picked from commit 76e737e)
Merged
Contributor
|
Looks like the backport caused breakage with rustix: uutils/coreutils#10871, uutils/coreutils#10844 |
tgross35
added a commit
that referenced
this pull request
Feb 11, 2026
Contributor
|
That's to be expected; we need to update when the upstream platform changes, and it would be unsound to continue using the definition from before this PR. Adding a note in the changelog #4967. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the makedev, major, and minor functions and fixes the type of dev_t on Redox. These functions are defines in the Redox libc, and are identical to the Linux implementations.
Sources
makedev, major, and minor are defined here: https://gitlab.redox-os.org/redox-os/relibc/-/blob/master/include/sys/sysmacros.h?ref_type=heads. These definitions are directly from musl, which matches the const fns in the libc crate.
The type of dev_t can be seen here: https://gitlab.redox-os.org/redox-os/relibc/-/blob/master/src/platform/types.rs?ref_type=heads#L66. It was recently adjusted to fix a discrepancy between 32-bit and 64-bit Redox systems.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI