[WIP] Add authenticated file download endpoint for beacons #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Singular namespace better reflects that a beacon accesses its own resources rather than a collection.
Beacons need to scope file access to only documents attached to their associated topics. The accessible_blobs method provides this authorization layer by joining through the attachments and beacon_topics associations to ensure beacons cannot access files from topics belonging to other beacons. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The endpoint allows beacons to download documents from their associated topics using the accessible_blobs scope for authorization. ActiveStorage streaming handles both full file downloads and partial content requests via Range headers for efficient delivery of large files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
oatkins8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves: #568
What Changed? And Why Did It Change?
Beacons need to download documents that are attached to their associated topics. Previously there was no endpoint to serve these files with proper authentication and authorization. This PR adds a files endpoint that allows beacons to download documents only from topics they have access to. The endpoint uses ActiveStorage streaming to support both full file downloads and partial content requests via Range headers, which is important for efficient delivery of large files.
The accessible_blobs method was added to the Beacon model to provide the authorization layer, ensuring beacons can only access documents from their own topics. The namespace was also standardised from beacons to beacon for consistency across the API.
How Has This Been Tested?
Comprehensive request specs cover authentication, authorization, full downloads, Range header support with single and multiple byte ranges, not found scenarios, and cross-beacon authorization checks. Model specs verify the accessible_blobs method correctly scopes files to the beacon's topics.