Skip to content

Improve Argument Error Message in EC:Group.new #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhenium merged 1 commit into from
Jan 4, 2026
+10 −1
Merged

Improve Argument Error Message in EC:Group.new #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/openssl/ossl_pkey_ec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ static VALUE ossl_ec_group_initialize(int argc, VALUE *argv, VALUE self)

break;
default:
ossl_raise(rb_eArgError, "wrong number of arguments");
ossl_raise(rb_eArgError, "wrong number of arguments (given %d, expected 1 or 4)", argc);
}

ASSUME(group);
Expand Down
9 changes: 9 additions & 0 deletions test/openssl/test_pkey_ec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,15 @@ def test_ec_group
assert_equal group1.degree, group4.degree
end

def test_ec_group_initialize_error_message
# Test that passing 2 arguments raises the helpful error
e = assert_raise(ArgumentError) do
OpenSSL::PKey::EC::Group.new(:GFp, 123)
end

assert_equal("wrong number of arguments (given 2, expected 1 or 4)", e.message)
end

def test_ec_point
group = OpenSSL::PKey::EC::Group.new("prime256v1")
key = OpenSSL::PKey::EC.generate(group)
Expand Down