reformat using clang-format #791
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
except for app/qtapp/
Have had the .clang-format for some time now and there has been no feedback. Here is a suggestion to adopt this format for most of the code, leaving app/qtapp/ for feedback from the author.
This is a purely mechanical format conversion, no hand editing, and should remain so. If there are issues then they should be corrected before if possible so that this is a mechanical reproducible patch. E.g. if can reorder header files, and there might be some code sections that want to skip reformatting.
This does create a burden when applying patches against other formats. But since it is a mechanical format conversion it is possible to apply this same format to code before and after a patch and then to make a new patch in the new format.
Keeping the current format means hand formatting patches from other branches using different formats which is somewhat unproductive and for large changes that becomes impractical.