Giving user a chance to use the original color of the icon, instead of always use a color filter#358
Giving user a chance to use the original color of the icon, instead of always use a color filter#358KyleXie wants to merge 2 commits intoroughike:masterfrom
Conversation
…ways use a filter color
|
Yes please. I have one icon with all rainbow colors but due to tintable imageview its impossible for me render original image on bottom bar |
|
Does this need to be merged in before we can use it? This is really frustrating. Can't change text color, can't use icons that have designed for me. White on white is pointless. I set my own TextAppearance style but of course it's still getting overriden by the library and using white. |
|
@KyleXie @MiralDesai @raviteja786143 is this still a thing you guys need even with the latest version? |
|
I'm no longer using this library so can't really say. I would say it's a good feature to have though, to allow developers to put their app's theme on the bottom bar. |
|
@yombunker sorry for late response, if someone already fixed this, please just close this PR. I'm not working on that project any more, so I'm not sure if the latest version works well. |
Some times, we would like to use the original image as the inactive tab icon, say, I have a semitransparent icon, after setColorFilter, it turns to opacity, that's not what I want, so I fixed it like this, if there's no FixedInactiveIconColor, we just clear the filter for unselected tab. Hope this helps.