Skip to content

Carousel didn't work well when inside horizontall scroll #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ems107 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Carousel didn't work well when inside horizontall scroll #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sharpnado.CollectionView.Droid/Renderers/CollectionViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ public static void Initialize()
{
}

public override bool OnInterceptTouchEvent(MotionEvent ev)
{
RequestDisallowInterceptTouchEvent(Element.HaveToDisallowInterceptTouchEvent);
return base.OnInterceptTouchEvent(ev);
}

protected override void OnElementChanged(ElementChangedEventArgs<CollectionView.RenderedViews.CollectionView> e)
{
base.OnElementChanged(e);
Expand Down
12 changes: 12 additions & 0 deletions Sharpnado.CollectionView/RenderedViews/CollectionView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,12 @@ public class CollectionView : View
typeof(CollectionView),
1);

public static readonly BindableProperty HaveToDisallowInterceptTouchEventProperty = BindableProperty.Create(
nameof(HaveToDisallowInterceptTouchEvent),
typeof(bool),
typeof(CollectionView),
false);

public CollectionView()
{
// default layout is VerticalList
Expand Down Expand Up @@ -365,6 +371,12 @@ public int ColumnCount
set => SetValue(ColumnCountProperty, value);
}

public bool HaveToDisallowInterceptTouchEvent
{
get => (bool)GetValue(HaveToDisallowInterceptTouchEventProperty);
set => SetValue(HaveToDisallowInterceptTouchEventProperty, value);
}

public Func<ViewCell, Task> PreRevealAnimationAsync { get; set; }

public Func<ViewCell, Task> RevealAnimationAsync { get; set; }
Expand Down