[v638][RF] Backport recent RooFit fix #20926
Merged
+46
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer needed due to root-project@3c37f0a (cherry picked from commit 7a9298c)
This fixes a regression introduced in 318faa0, where I forgot to backfill newly-created hash tables. A unit test with the reproducer from the issue is also implemented. Closes root-project#20904. (cherry picked from commit 2673534)
Some simple RooFit unit tests are grouped in a single executable to not create too many test executabled. (cherry picked from commit c0b8e85)
Test Results 20 files 20 suites 3d 13h 19m 52s ⏱️ For more details on these failures, see this check. Results for commit f35595d. |
guitargeek
merged commit 35b1216
into
root-project:v6-38-00-patches
28 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a fix to a regression in RooFit in ROOT 6.38