Skip to content

Conversation

@silverweed
Copy link
Contributor

TL;DR: adds support for treating -Dfoo as -D foo. See header documentation for details.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed self-assigned this Jan 16, 2026
@silverweed silverweed requested a review from pcanal as a code owner January 16, 2026 15:33
@devajithvs
Copy link
Contributor

I feel like this approach is a bit too limiting. If you have a short-flag starting with a certain character, you can't define any other option that starts with the same character.

In LLVM, they have a specific argument you can pass when creating a prefix option, something like:

gOptPPDefines("D", cl::Prefix, ...);

Could we support something similar? For example:

opts.AddFlag({"-D"}, ROOT::RCmdLineOpts::EFlagType::kPrefixArg, ...);

@github-actions
Copy link

Test Results

    11 files      11 suites   1d 6h 17m 38s ⏱️
 3 786 tests  3 786 ✅ 0 💤 0 ❌
36 183 runs  36 183 ✅ 0 💤 0 ❌

Results for commit 2f2f38e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants