[RF] Fixup RooLinkedList::setHashTableSize()
#20914
Merged
+46
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hageboeck
approved these changes
Jan 16, 2026
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
I would have preferred to have the fix and the changes to the tests in two different commits. If you would need to change something else, that could be an item that could be addressed in the same go.
Contributor
Author
|
No problem, I'll split it up. Thanks for the review! |
ferdymercury
suggested changes
Jan 16, 2026
This fixes a regression introduced in 318faa0, where I forgot to backfill newly-created hash tables. A unit test with the reproducer from the issue is also implemented. Closes root-project#20904.
Some simple RooFit unit tests are grouped in a single executable to not create too many test executabled.
guitargeek
force-pushed
the
issue-20904
branch
from
87b501c to
9c62f44
Compare
ferdymercury
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 318faa0, where I forgot to backfill newly-created hash tables.
A unit test with the reproducer from the issue is also implemented.
Some simple RooFit unit tests are grouped in a single executable to not create too many test executabled.
Closes #20904.
Needs to be backported to ROOT 6.38