[cppyy] Mark most of the xfail-ed tests as "strict"
#20906
Conversation
guitargeek
force-pushed
the
issue-20085
branch
from
519d892 to
5f370c9
Compare
Test Results 22 files 22 suites 3d 16h 2m 42s ⏱️ For more details on these failures, see this check. Results for commit 5f370c9. |
guitargeek
force-pushed
the
issue-20085
branch
2 times, most recently
from
e36515c to
16ab12d
Compare
| else if (name == "basic_string<wchar_t,char_traits<wchar_t>,allocator<wchar_t> >" | ||
| || name == "std::basic_string<wchar_t,char_traits<wchar_t>,allocator<wchar_t> >" | ||
| ) { |
There was a problem hiding this comment.
This is not exactly how it's done upstream
else if (name == "std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >") {
So I don't understand the commit message
There was a problem hiding this comment.
You're right, I got that wrong! I got confused when reading these long types. I'll fix this up.
There was a problem hiding this comment.
Updated. I think I got it right now.
| def has_cpp_20(): | ||
| import cppyy | ||
|
|
||
| return cppyy.gbl.gInterpreter.ProcessLine("__cplusplus;") >= 202002 |
There was a problem hiding this comment.
How does this work? ProcessLine is returning an integer corresponding to the value of __cplusplus?
There was a problem hiding this comment.
That's correct. I got this pattern from the upstream cppyy test suite:
https://github.com/wlav/cppyy/blob/92967c195e47361dc04a6f1b0a77cfc745f4d914/test/test_stltypes.py#L1673
Follows up on 760b6cc, where not all possible type names were used to match `std::wstring`. Somtimes, the initial `basic_string` part is still prefixed with `std::`. This enables the `test02_string_data_access` unit test in `test_stltypes` from the cppyy test suite on all platforms.
This means the tests will fail if it unexpectedly passes.
guitargeek
force-pushed
the
issue-20085
branch
2 times, most recently
from
297fcf0 to
f6691d8
Compare
guitargeek
force-pushed
the
issue-20085
branch
from
f6691d8 to
cead627
Compare
2 participants
If tests are actually passing, they should not be skipped. This is enforced by the
strict=Truekeyword of thexfailmarker, which makes the tests fail if it unexpectedly succeeded.First step towards closing #20085.