perf: replace startsWith with strict equality#1901
Open
btea wants to merge 1 commit intorollup:masterfrom
Open
perf: replace startsWith with strict equality#1901btea wants to merge 1 commit intorollup:masterfrom
btea wants to merge 1 commit intorollup:masterfrom
Conversation
Collaborator
|
As always thanks for the PR. I'm not going to approve this, however. It's a micro-optimization at the expense of readability with no clear advantage that any typical user will realize. |
Contributor
Author
|
Yes, this is a very limited modification unless there is extensive triggering logic. Feel free to turn it off, thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
{name}This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
When determining the value of the first letter of a string, using strict equality is more efficient than startsWith. refer to link