[Graphite MQ] Draft PR GROUP:spec_3ed000 (PRs 4168, 4170, 4211, 4227, 4228, 4243)

[graphite-app]

This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.

The following PRs are included in this draft PR:

• #4168
• #4170
• #4211
• #4227
• #4228
• #4243

[railway-app]

This PR was not deployed automatically as @graphite-app[bot] does not have access to the Railway project.

In order to get automatic PR deploys, please add @graphite-app[bot] to your workspace on Railway.

[claude]

PR Review: Graphite MQ Group (PRs #4168, #4170, #4211, #4227, #4228, #4243)

This is a large batch covering: Ladle component environment, XYFlow workflow visualization, database inspector, inspector app separation, inspector-from-manager serving, and a setupDatabase merge fix. Overall the work is solid, but there are a few issues worth addressing before merging.

---

Critical

Absolute symlink committed to version control (frontend/apps/inspector/public)

The symlink target is an absolute path on a specific developer's machine:

+/Users/kwojciechowski/Documents/Projects/rivet.gg/rivet/frontend/public

This will silently break builds on every other machine (and in CI). It should be a relative symlink (../../public from frontend/apps/inspector/) or the path should be resolved differently in the Vite config.

---

Significant

Duplicate DbMutex class (src/db/mod.ts and src/db/drizzle/mod.ts)

Two independent implementations of the same class were added. The version in drizzle/mod.ts has separate acquire/release methods plus run, while mod.ts only has run. They should be consolidated into a single shared utility (e.g., src/db/mutex.ts) to avoid drift.

Incomplete column metadata in getDatabaseSchema() (src/inspector/actor-inspector.ts)

Column info is derived from SELECT * FROM table LIMIT 1, which means:

• Tables with zero rows will appear to have no columns
• All column types are returned as ""
• notnull, pk, and dflt_value are always zero/null/hardcoded

SQLite provides PRAGMA table_info("tablename") and PRAGMA foreign_key_list("tablename") which give accurate, complete metadata without needing sample data. Given the frontend types already have notnull: boolean and pk: boolean | null, this data can easily be wired up.

Extraction target is unscopable (src/inspector/serve-ui.ts)

The tarball always extracts to os.tmpdir() + "/rivetkit-inspector". Two issues:

1. Multiple processes (or different versions of the package) will share the same extraction directory, potentially serving stale files.
2. If extraction fails mid-way, a partial directory remains at that path. On the next attempt extractionPromise is already set (to a rejected promise), so the function will keep returning that error until the process restarts.

Suggested mitigations: include the package version in the dest path (e.g., rivetkit-inspector-{version}), and clear extractionPromise on failure to allow retries.

---

Minor

Commented-out code left in (frontend/src/components/actors/actor-traces.tsx)

The ToggleGroup block is commented out with a JSX comment. This should either be removed or tracked in an issue; dead code in JSX makes it hard to know if it's intentional or forgotten.

Missing newline at end of file (src/utils/node.ts)

The diff shows \ No newline at end of file for the getNodeUrl addition at the end of the file.

Leading blank line in new file (src/inspector/serve-ui.ts)

There's an extra blank line before the first import statement.

Indentation in new files (tsup.browser.config.ts, src/inspector/mod.browser.ts)

These new files use 4-space indentation. The project convention (per rustfmt.toml and the rest of the TypeScript files) is tabs.

---

Observations (not blocking)

getInspectorProtocolVersion jump from 2 to 3 (actor-inspector-context.tsx)

The previous code mapped "traces" → 3, "queue" → 4. This PR collapses that to just "database" → 3. If there are old clients that reported version 4 in the field, the mapping change might cause incorrect downgrade behavior. Worth a quick sanity check that the version ladder is intentional.

#activeKeepAwakeCount fix in actor/instance/mod.ts

The increment before action dispatch and decrement in the finally block is a good fix for actions preventing premature actor sleep. The guard that clamps the count to 0 with a warning is a nice defensive addition.

instanceof Promise → thenable duck-type check

Switching from instanceof Promise to checking typeof maybeThenable.then === 'function' is correct and handles cross-realm promises (e.g., from vm contexts or different global objects).

Inspector now served locally at /ui/

Removing the dependency on inspect.rivet.dev simplifies the local dev story. The redirect from /ui → /ui/ is a nice UX touch for SPA base-path handling.

XYFlow workflow visualizer refactor

The 1882-line component replaced by ~100 lines + dedicated layout/node files is a big improvement for maintainability.