chore: simplify queue api#4229
chore: simplify queue api#4229NathanFlurry wants to merge 1 commit intofeat-add-typed-event-and-queue-schemas-for-actorsfrom
Conversation
|
🚅 Deployed to the rivet-pr-4229 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: chore: simplify queue apiThis PR significantly simplifies the queue API both on the client side (replacing the proxy-based Positives
Issues / Concerns1. Schema validation silently removed from The 2.
3. TypeScript overload resolution cannot pick between the two 4. New nullable fields in persisted message format without visible migration
5. If 6. The while condition only checks 7. The function matches any object with a non-undefined 8. Minor: docs no longer mention message durability guarantee The updated Nits
Summary: The core design is solid and the ergonomics are meaningfully better. The main things to verify before merge are: (1) persisted message format backward compatibility, (2) whether |
e5ca3f5 to
fb5b6a1
Compare
fb5b6a1 to
bb8536a
Compare
bb8536a to
4a8982c
Compare
4a8982c to
0545191
Compare
0545191 to
b9aca01
Compare
b9aca01 to
ee35c6c
Compare
fb17656 to
8da1c60
Compare
8da1c60 to
a1f946a
Compare
ee35c6c to
8d79ee3
Compare
8d79ee3 to
8b13f68
Compare
8b13f68 to
8d79ee3
Compare
Merge activity
|
# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: