feat: add RSA-OAEP padding support with backwards compatibility#5
Open
script3r wants to merge 1 commit intorishabhyadavv:mainfrom
Open
feat: add RSA-OAEP padding support with backwards compatibility#5script3r wants to merge 1 commit intorishabhyadavv:mainfrom
script3r wants to merge 1 commit intorishabhyadavv:mainfrom
Conversation
Add optional `padding` parameter to RSA encryption/decryption functions that allows choosing between PKCS1 (legacy) and OAEP (recommended) padding. **Why OAEP?** - PKCS#1 v1.5 padding is vulnerable to padding oracle attacks (Bleichenbacher's attack) - OAEP (Optimal Asymmetric Encryption Padding) provides provable security - OAEP is recommended by NIST and modern security standards **Backwards Compatibility** - All existing code continues to work without changes - The `padding` parameter defaults to `'PKCS1'` - Users can opt-in to OAEP by passing `'OAEP'` as the third parameter **Usage** ```typescript // Existing code works unchanged (uses PKCS1) const encrypted = encryptRSA(data, publicKey); // Opt-in to more secure OAEP padding const encrypted = encryptRSA(data, publicKey, 'OAEP'); ``` **Affected functions** - encryptRSA / decryptRSA - encryptAsyncRSA / decryptAsyncRSA Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for RSA-OAEP (Optimal Asymmetric Encryption Padding) while maintaining full backwards compatibility with existing code using PKCS#1 v1.5 padding.
Why OAEP?
PKCS#1 v1.5 (current default) has known vulnerabilities:
OAEP provides stronger security guarantees:
Backwards Compatibility
paddingparameter defaults to'PKCS1''OAEP'API Changes
Usage
Implementation Details
RSA/ECB/PKCS1PaddingRSA/ECB/OAEPWithSHA-256AndMGF1PaddingSecKeyAlgorithm.rsaEncryptionPKCS1SecKeyAlgorithm.rsaEncryptionOAEPSHA256🤖 Generated with Claude Code