Fix reflection warnings in the ring.adapter.jetty namespace#539
Conversation
|
Thanks for the PR - I'm not sure how I missed this! I would love a PR that enables reflection warnings, but it's more work than it sounds. Ideally we just add We could set So that leaves going through the tests and fixing all the reflection, which seems like the correct solution, but is also a fair bit of work. This is why I elected to test all the namespaces manually before releasing 1.15.2, but clearly I somehow missed the reflection in the Jetty adapter. |
I can take a look at how much work this would entail. Thanks for the quick turnaround! |
Because it reflects, the
ring.adapter.jetty/proxy-handlerfunction showed up quite prominently on a recording of an app running in production.This change fixes all reflection warnings in the
ring.adapter.jettynamespace.Would you be willing to entertain a PR that enables reflection warnings throughout the project, either via
:global-vars {*warn-on-reflection* true}or(set! *warn-on-reflection* true)at the top of every namespace that does Java interop (perhaps coupled with the:warn-on-reflectionclj-kondo linter)?