Skip to content

Conversation

@ericokuma
Copy link
Contributor

@ericokuma ericokuma commented Dec 19, 2025

Ensures the Cell Inspector remains open when locked, even when clicking outside of it. This fixes APP-399, allowing users to reference locked cell details while interacting with the dashboard.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Linear Issue: APP-399

Open in Cursor Open in Web


Note

Ensure Cell Inspector stays open when locked by ignoring outside clicks, with minor guard/early-return refactor in the click-outside handler.

  • Click-outside behavior updated in CellInspector.svelte: Early-return if not open/inside click; when isLocked, ignore outside clicks to keep the inspector visible; otherwise close as before.

Written by Cursor Bugbot for commit fa3725f. This will update automatically on new commits. Configure here.

Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
@cursor
Copy link

cursor bot commented Dec 19, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@ericokuma ericokuma marked this pull request as ready for review December 22, 2025 21:54
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to merge main to fix the failing CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants