Explore dimensions copy indicator #8551
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
This commit restructures the leaderboard row component to enhance accessibility by adding role, tabindex, and focus/pointerover event handlers to cells. It also refines the styling and layout of the cells, particularly for the dimension and measure values, and introduces a new `display: contents` style for tooltips. Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses APP-657 by improving the discoverability of the "Shift + Click to copy" functionality on the main dashboard.
Previously, the copy hint was only visible within expanded dimension tables, leading to users being unaware of this feature. This PR introduces a reusable
CopyShortcutTooltipcomponent that displays the "Shift + Click to copy" hint on hover for all copy-enabled cells in theLeaderboardRow. The tooltip auto-hides after 3 seconds to remain unobtrusive, making the copy functionality more apparent to all users.Checklist:
Linear Issue: APP-657