Skip to content

Conversation

@jetersen
Copy link
Contributor

No description provided.

Copy link
Owner

@rgl rgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you also creating a modified gitlab container to point to this service?

How about certificate validation?

I have mix feelings about using an environment variable with the same name has the argument. It should have some prefix. Also, why can't you pass the command line arguments instead of using environment variables?

Why not use make to build the binary?

Do we really need the Ubuntu base image to run a go application?

@jetersen
Copy link
Contributor Author

jetersen commented Sep 13, 2018

We use a separate nginx as our reverse proxy to handle all traffic to both this service and Gitlab.

# RUN apk --no-cache add ca-certificates is there to demonstrate you will need to load a certificate if have your own root ca or perhaps a untrusted chain I can perhaps make a the full example 😅

Using make seems unnecessary

Ubuntu was because I was unclear what dependency it needed and alpine base image was not good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants