Deep audit fixes: Enhanced FFmpeg transcoding capabilities#38
Merged
alokemajumder merged 2 commits intomainfrom Dec 7, 2025
Merged
Deep audit fixes: Enhanced FFmpeg transcoding capabilities#38alokemajumder merged 2 commits intomainfrom
alokemajumder merged 2 commits intomainfrom
Conversation
## FFmpegWrapper fixes: - Updated validate_operations with all new operation types - Fixed trim handler to support both 'start'/'start_time' naming - Allow empty operations list ## Enhanced transcode operation: - Added profile support (baseline, main, high, high10, high422, high444) - Added pixel format support (yuv420p, yuv422p, yuv444p, 10-bit) - Added hardware acceleration preference (auto, none, nvenc, qsv, vaapi) - Added VBV buffer control (max_bitrate, buffer_size) - Added GOP size (keyframe interval) control - Added B-frames control - Added audio sample rate and channels - Added faststart flag for web streaming - Added two-pass encoding flag ## New codec support: - Video: prores, dnxhd - Audio: eac3, flac, pcm_s16le, pcm_s24le
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses gaps found during the deep FFmpeg integration audit to ensure the API can fully utilize FFmpeg's capabilities.
FFmpegWrapper Fixes
validate_operationsmethod with all new operation types (was missing scale, crop, rotate, flip, audio, subtitle, concat)start/start_timeandend/end_timenaming conventionsEnhanced Transcode Operation
New Codec Support
Example Payloads
Professional H.264 encode with VBV
{ "input": "/storage/input/video.mp4", "output": "/storage/output/broadcast.mp4", "operations": [{ "type": "transcode", "video_codec": "h264", "profile": "high", "preset": "slow", "video_bitrate": "8M", "max_bitrate": "10M", "buffer_size": "20M", "gop_size": 48, "b_frames": 2, "pixel_format": "yuv420p" }] }Hardware-accelerated encode
{ "input": "/storage/input/video.mp4", "output": "/storage/output/fast.mp4", "operations": [{ "type": "transcode", "video_codec": "h264", "hardware_acceleration": "nvenc", "crf": 23 }] }Test plan