Fix critical bugs and add missing storage module#34
Merged
gensecai-dev merged 1 commit intomainfrom Dec 7, 2025
Merged
Conversation
Critical fixes: - Created missing storage module with backends: - storage/base.py: Abstract StorageBackend base class - storage/factory.py: Backend factory function - storage/local.py: Local filesystem backend - storage/s3.py: S3-compatible backend - storage/azure.py: Azure Blob Storage placeholder - storage/gcs.py: Google Cloud Storage placeholder - Fixed api/models/api_key.py: - Corrected generate_key() return type annotation to tuple[str, str, str] - Fixed api/models/job.py: - Added missing columns: current_stage, status_message, updated_at, processing_stats - Fixed api/services/job_service.py: - Changed input_url/output_url to input_path/output_path to match Job model - Added null check for job.operations
gensecai-dev
approved these changes
Dec 7, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deep audit uncovered critical bugs that would prevent the application from running. This PR fixes all identified issues.
Critical Fixes
1. Missing Storage Module (CRITICAL)
The codebase imported from
storage.factoryandstorage.basethroughout, but the entirestorage/module was missing. Created complete storage module with:StorageBackendbase class defining the interfacecreate_storage_backend()for instantiating backends2. Type Annotation Bug (api/models/api_key.py)
generate_key() -> tuple[str, str]generate_key() -> tuple[str, str, str]3. Missing Job Model Columns (api/models/job.py)
Added missing columns that were being referenced by
worker/utils/progress.py:current_stage- Alias for stage compatibilitystatus_message- Status message for progress updatesupdated_at- Last update timestampprocessing_stats- JSON field for processing statistics4. Wrong Column Names (api/services/job_service.py)
job.input_url->job.input_pathjob.output_url->job.output_pathjob.operationsFiles Changed
Test plan