Skip to content

WIP: Patch dmap reset and patchable #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ericson2314 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

WIP: Patch dmap reset and patchable #2

Ericson2314 wants to merge 5 commits into from

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 8, 2020 •
edited
Loading

@Ericson2314 Ericson2314 mentioned this pull request Jan 8, 2020
Closed
@Ericson2314
Copy link
Member Author

Ericson2314 commented Jan 9, 2020 •
edited
Loading

I think I want Patchable to live in a separate library; maybe just make https://github.com/obsidiansystems/partial-map Patchable and have it depend on this library, because I am not sure it is a good idea to intermingle patches and patch targets in the same channel. We do do it today of course, but if we put it in this library then we are condoning it, and I wouldn't want others to start doing that if they don't already.

@Ericson2314 Ericson2314 mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @danbornside