Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2536 +/- ##
==========================================
- Coverage 95.70% 95.68% -0.02%
==========================================
Files 456 457 +1
Lines 4561 4564 +3
Branches 524 524
==========================================
+ Hits 4365 4367 +2
- Misses 127 128 +1
Partials 69 69
☔ View full report in Codecov by Sentry. |
leibale
left a comment
There was a problem hiding this comment.
Overall looks good, some small changes are needed..
Thanks for contributing!
| wait: WAIT | ||
| wait: WAIT, | ||
| WAITAOF, | ||
| waitaof: WAITAOF |
There was a problem hiding this comment.
Change to waitAOF or waitAof (I'm actually not sure which one we should go with :P)
| [1, 0] | ||
| ); | ||
| }, GLOBAL.SERVERS.OPEN); | ||
| }); No newline at end of file |
| ]; | ||
| } | ||
|
|
||
| export declare function transformReply(): Array<[number, number]>; No newline at end of file |
|
@leibale Thanks for reviewing! I make some changes according to your feedback. Please take a look whenever you have time. |
WAITAOF
Description
Fix #2458
Checklist
npm testpass with this change (including linting)?