Support ZRANK and ZREVRANK: Added the optional WITHSCORE argument#2489
Support ZRANK and ZREVRANK: Added the optional WITHSCORE argument#2489codrin-ch wants to merge 7 commits intoredis:masterfrom
Conversation
|
@codrin-ch thanks for contributing! |
…onal WITHSCORE argument
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
==========================================
- Coverage 95.71% 95.64% -0.08%
==========================================
Files 458 460 +2
Lines 4531 4543 +12
Branches 506 506
==========================================
+ Hits 4337 4345 +8
- Misses 127 131 +4
Partials 67 67
☔ View full report in Codecov by Sentry. |
|
I think the coverage missing is due to the redis version from the testing cluster. |
|
@codrin-ch this is exactly what is happening. I'll add Redis 7.2 to the tests matrix soon. |
|
@codrin-ch sorry for the long delay, but looks like the tests are failing (you can ignore the "ACL GETUSER" test, but:
https://github.com/redis/node-redis/actions/runs/5037516252/jobs/9034411168?pr=2489#step:7:2430 If you don't have time to work on it, I'll take it from here and finish it, just let me know.. :) |
|
Can something be done to finish this? |
Description
Checklist
npm testpass with this change (including linting)?fix #2463 and #2464