Conversation
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
One broken link; otherwise, LGTM.
| </a> | ||
| </div> | ||
| <p class="text-sm text-gray-300 text-center mt-4"> | ||
| Search the <a href="/commands" class="text-redis-yellow-500 hover:underline">complete command reference</a> and the <a href="/integrate" class="text-redis-yellow-500 hover:underline">integrated libraries and tools</a> |
There was a problem hiding this comment.
href="/integrate" results in a 404
There was a problem hiding this comment.
thanks I'll fix this
cmilesb
left a comment
cmilesb
left a comment
There was a problem hiding this comment.
This is a partial review. I'd be happy to make some of these changes myself in a separate PR.
|
|
||
| <!-- Redis Cloud --> | ||
| <div class="flex flex-col bg-redis-ink-900 border-2 border-redis-red-500 rounded-md overflow-hidden"> | ||
| <div class="px-4 py-2 border-b border-redis-pen-400"> |
There was a problem hiding this comment.
I think it would be useful to have these be buttons as well leading to the home page of each section. In my testing changing "div" to "a" seems to work, and adding the style to transition colors. Would be happy to make the changes myself.
| </div> | ||
|
|
||
| <!-- Redis Cloud --> | ||
| <div class="flex flex-col bg-redis-ink-900 border-2 border-redis-red-500 rounded-md overflow-hidden"> |
There was a problem hiding this comment.
I don't mind the border and red text here too much, but I really don't like the fact that the background is the same color as the page background.
I'd recommend changing this color to match the software color, but then the Red color doesn't contrast well enough for the text. (Actually, as it stands, the text/background could be contrasted a little more - it seems to pass most of the tests but not all of them.) Happy to test colors myself here to see what works best. Maybe also a "Recommended" badge to make it stand out?
There was a problem hiding this comment.
Thank you so much Cameron! Yes, any changes you want to work on would be great.
|
The main thing I notice is that the full-width layout and the narrow mobile layout work OK, but in the "intermediate" width layout, the nav buttons at the left display on top of the content. However, this also happens with the current layout, so maybe we've decided it's not an issue? Anyway, I think the new layout looks pretty good and it crams more information into a smaller space. |
Co-authored-by: Cameron Bates <102550101+cmilesb@users.noreply.github.com>
Co-authored-by: Cameron Bates <102550101+cmilesb@users.noreply.github.com>
Co-authored-by: Cameron Bates <102550101+cmilesb@users.noreply.github.com>
4 participants
Here is a new draft of the docs home page in response to feedback that the current one is overwhelming and to help make the main options more clear at the top of the page. Any and all feedback welcomed and no rush on this one https://redis.io/docs/staging/doc-home-update/