-
Notifications
You must be signed in to change notification settings - Fork 94
feat(x2a): K8s jobs real implementation - framework + init #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x2a): K8s jobs real implementation - framework + init #2273
Conversation
244e392 to
d1b3754
Compare
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
workspaces/x2a/plugins/x2a-backend/src/services/JobResourceBuilder.ts
Outdated
Show resolved
Hide resolved
| # Git commit | ||
| echo "=== Committing changes to git ===" | ||
| cd ${TARGET_BASE} | ||
| git add "${PROJECT_DIR}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for heads-up:
Do we want to commit everything? Including temporary data like the checklist?
Or should we focus on the artifacts only?
Can be good for debugging but messy otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could commit less, but we need to decide what the user should see and approve, and what not
lets discuss separately on what would be included
f2eecc3 to
152fc8f
Compare
Changed Map<string, string[]> to Map<string, Artifact[]> in listJobsForProject and listJobsForModule methods. Updated artifact queries to select all fields and use mapRowToArtifact for proper type mapping. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
152fc8f to
c7e5878
Compare
|
|
LGTM. |


Overview
This PR implements real Kubernetes job creation for the X2A migration plugin, enabling the init phase to run x2a migration jobs on Kubernetes with full git flow.
Key Changes
TODOs
with actual x2a tool integration
https://issues.redhat.com/browse/FLPATH-3086