Don't create extra functions for MultiTrigger handlers #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yay295 <Yay295@users.noreply.github.com>
niedzielski
reviewed
Dec 17, 2024
Comment on lines
405
to
408
| this.addTrigger({ | ||
| event: eventType, | ||
| onEvent: (event: OnTriggerRequest, context: TriggerContext) => | ||
| (triggerDefinition.onEvent as TriggerOnEventHandler<OnTriggerRequest>)(event, context), | ||
| onEvent: triggerDefinition.onEvent, | ||
| } as any); // eslint-disable-line @typescript-eslint/no-explicit-any |
Contributor
There was a problem hiding this comment.
I think we can drop the lint too:
this.addTrigger({
event: eventType,
onEvent: triggerDefinition.onEvent as TriggerOnEventHandler<OnTriggerRequest>,
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Devvit.addTrigger()currently creates unnecessary copies of the trigger handler for MultiTriggers.🧪 Testing Steps / Validation
I made this change directly on the GitHub website. I haven't tested anything.
✅ Checks