Differentiate servers running within a single runtime#705
Open
gregbarasch wants to merge 4 commits intoreddit:masterfrom
Open
Differentiate servers running within a single runtime#705gregbarasch wants to merge 4 commits intoreddit:masterfrom
gregbarasch wants to merge 4 commits intoreddit:masterfrom
Conversation
Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
Member
konradreiche
left a comment
There was a problem hiding this comment.
This makes sense to me but I believe we don't have the equivalent in baseplate v2. I've added @kylelemons for additional perspective.
kylelemons
reviewed
Dec 30, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Our thrift server metrics assume that there will only be one server running within a single runtime. This is not always true. If a second server is running, the thrift server metrics will clash with one another. This PR adds a serverName label to our serverside metrics.
📜 Details
This update is backwards compatible, and notably should not increase cardinality in any significant way. Preexisting metric usage will emit "unknown" as the serverName, which will retain metric cardinality and will add a negligible amount of data for metric DBs.
The API itself does not enable backward compatible attribute changes. We have a choice. We can:
Commonly, we might make use of the optionals or builder pattern for forward looking, backwards compatible changes. Instead though we've opted to use a Cfg struct, as this matches patterns found elsewhere in the repo.
🧪 Testing Steps / Validation
Unit tests
✅ Checks